Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the max_relative_error of QR's grad checker #42221

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

aoyulong
Copy link
Contributor

@aoyulong aoyulong commented Apr 25, 2022

PR types

Bug fixes

PR changes

OPs

Describe

  • Some of the unit tests of QR grad computation failed in CUDA 11.4 and can be fixed by changing the seed from 4 to 7.
  • After examining the diff values, we found the actual max_relative_error is between 1e-6 and 1e-7. To avoid the failed tests caused by the random inputs, the max_relative_error is set to 1e-6 while keeping the numeric_grad_delta unchanged.

Copy link
Contributor

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aoyulong aoyulong merged commit 4c80385 into PaddlePaddle:develop Apr 27, 2022
aoyulong added a commit to aoyulong/Paddle that referenced this pull request Aug 1, 2022
fuyinno4 pushed a commit that referenced this pull request Aug 3, 2022
* Adjust the relative error of QR's grad (#42221)

* Fix the format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants