Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 3 No.17】为 Paddle 新增 sgn #44568

Merged
merged 13 commits into from
Aug 11, 2022
Merged

【PaddlePaddle Hackathon 3 No.17】为 Paddle 新增 sgn #44568

merged 13 commits into from
Aug 11, 2022

Conversation

peachlcy
Copy link
Contributor

@peachlcy peachlcy commented Jul 23, 2022 •
edited by luotao1
Loading

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot
Copy link

paddle-bot bot commented Jul 23, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 23, 2022
@peachlcy peachlcy mentioned this pull request Jul 23, 2022
Closed
@luotao1
Copy link
Contributor

luotao1 commented Jul 26, 2022

请先修复下多条失败CI的问题

luotao1
luotao1 reviewed Jul 27, 2022
View reviewed changes
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_sgn.py Show resolved Hide resolved
luotao1
luotao1 reviewed Aug 1, 2022
View reviewed changes
python/paddle/fluid/tests/unittests/test_sgn.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
@luotao1 luotao1 requested a review from Ligoml August 3, 2022 03:42
@luotao1
Copy link
Contributor

luotao1 commented Aug 3, 2022 •
edited
Loading

LGTM @peachlcy PR-CI-Codestyle-Check流水线没有过，请修改下格式

@Ligoml
Copy link
Contributor

Ligoml commented Aug 4, 2022

需要补充中文API文档到 docs

@peachlcy
Merge remote-tracking branch 'peach/develop' into add_sgn
faae5fa 
# Conflicts:
#	python/paddle/tensor/__init__.py
@peachlcy peachlcy mentioned this pull request Aug 4, 2022
Merged
@peachlcy
Copy link
Contributor Author

peachlcy commented Aug 4, 2022

需要补充中文API文档到 docs

已添加

SigureMo
SigureMo requested changes Aug 4, 2022
View reviewed changes
python/paddle/tensor/__init__.py Outdated Show resolved Hide resolved
python/paddle/tensor/__init__.py Show resolved Hide resolved
Ligoml
Ligoml reviewed Aug 5, 2022
View reviewed changes
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
@Ligoml
Copy link
Contributor

Ligoml commented Aug 8, 2022

中文文档的pr也辛苦改一下~

@peachlcy
Copy link
Contributor Author

peachlcy commented Aug 9, 2022

中文文档的pr也辛苦改一下~

中文文档用的是COPY-FROM: paddle.sgn

@SigureMo
Copy link
Member

SigureMo commented Aug 9, 2022 •
edited
Loading

中文文档用的是COPY-FROM: paddle.sgn

应该是说中文文档那边的一些其他问题，看起来都还没有改

@peachlcy
Copy link
Contributor Author

peachlcy commented Aug 9, 2022

中文文档用的是COPY-FROM: paddle.sgn

应该是说中文文档那边的一些其他问题，看起来都还没有改

已修改

Ligoml
Ligoml approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@jeff41404
Copy link
Contributor

rfc should be included in PR Describe above.

jeff41404
jeff41404 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Aug 11, 2022

rfc should be included in PR Describe above.

rfc已经添加到PR描述中。

@luotao1 luotao1 merged commit f7a0bfa into PaddlePaddle:develop Aug 11, 2022
@SigureMo SigureMo mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligoml Ligoml Ligoml approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@luotao1 luotao1 Awaiting requested review from luotao1

@SigureMo SigureMo Awaiting requested review from SigureMo

Assignees

@luotao1 luotao1

@Ligoml Ligoml

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peachlcy @CLAassistant @luotao1 @Ligoml @SigureMo @jeff41404