-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JitLayer]Polish PEFuntion to speed up JitLayer and fix memory leak #44738
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,10 +19,14 @@ | |
#include <vector> | ||
|
||
#include "paddle/fluid/framework/block_desc.h" | ||
#include "paddle/fluid/framework/details/build_strategy.h" | ||
#include "paddle/fluid/framework/details/execution_strategy.h" | ||
#include "paddle/fluid/framework/executor_cache.h" | ||
#include "paddle/fluid/framework/ir/graph.h" | ||
#include "paddle/fluid/framework/program_desc.h" | ||
#include "paddle/fluid/framework/scope.h" | ||
#include "paddle/fluid/framework/variable.h" | ||
#include "paddle/phi/core/enforce.h" | ||
|
||
#include "paddle/fluid/jit/base_function.h" | ||
#include "paddle/fluid/jit/function_schema.h" | ||
|
@@ -31,72 +35,99 @@ | |
namespace paddle { | ||
namespace jit { | ||
|
||
using ExecutionStrategy = framework::details::ExecutionStrategy; | ||
using ParallelExecutor = framework::ParallelExecutor; | ||
using Graph = framework::ir::Graph; | ||
|
||
class PEFunction : public BaseFunction { | ||
public: | ||
PEFunction(const std::shared_ptr<FunctionInfo> &info, | ||
const Name2VariableMap ¶ms_dict, | ||
const phi::Place &place) | ||
: info_(info), place_(place) { | ||
info_->RemoveDescFeedFetch(); | ||
PADDLE_ENFORCE_GT( | ||
static_cast<int64_t>(info_->ProgramDesc().Block(0).OpSize()), | ||
0, | ||
platform::errors::PreconditionNotMet( | ||
"There is no operator in ProgramDesc.")); | ||
utils::ShareParamsIntoScope(info_->ParamNames(), params_dict, &scope_); | ||
VLOG(6) << framework::GenScopeTreeDebugInfo(&scope_); | ||
info_->RemoveDescFeedFetch(); | ||
CreateGraphAndPE(); | ||
} | ||
|
||
~PEFunction() noexcept {} | ||
|
||
std::vector<Tensor> operator()(const std::vector<Tensor> &inputs) { | ||
auto dense_tensors = utils::ToDenseTensors(inputs); | ||
return utils::ToTensors(this->operator()(dense_tensors)); | ||
static ExecutionStrategy GetExecutionStrategy(const platform::Place &place) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GetExecutionStrategy 函数不建议作为PEFunction的静态成员方法。下个拆目录的PR里,把这个函数放到 pe_function.cc 中吧,并作为一个局部静态方法,仅在pe_function.cc 编译单元里可见 |
||
ExecutionStrategy execution_strategy; | ||
|
||
auto device_type = platform::Place2DeviceType(place); | ||
switch (device_type) { | ||
case platform::DeviceType::CPU: { | ||
execution_strategy.num_threads_ = 2; | ||
break; | ||
} | ||
case platform::DeviceType::CUDA: { | ||
// NOTE: According experiments, one thread is faster in | ||
// most model training. | ||
execution_strategy.num_threads_ = 1; | ||
break; | ||
} | ||
case platform::DeviceType::XPU: { | ||
execution_strategy.num_threads_ = 1; | ||
break; | ||
} | ||
case platform::DeviceType::IPU: { | ||
execution_strategy.num_threads_ = 1; | ||
break; | ||
} | ||
default: | ||
PADDLE_THROW(platform::errors::Unavailable( | ||
"Unsupported Device type %d.", device_type)); | ||
} | ||
execution_strategy.use_device_ = device_type; | ||
|
||
return execution_strategy; | ||
} | ||
|
||
std::vector<DenseTensor> operator()(const std::vector<DenseTensor> &inputs) { | ||
std::string prog_string; | ||
std::hash<std::string> string_hash; | ||
void CreateGraphAndPE() { | ||
framework::details::BuildStrategy build_strategy; | ||
auto execution_strategy = GetExecutionStrategy(place_); | ||
|
||
auto &program_desc = info_->ProgramDesc(); | ||
// TODO(dev): Serialize is very slow. | ||
const_cast<framework::ProgramDesc *>(&program_desc) | ||
->Proto() | ||
->SerializePartialToString(&prog_string); | ||
int64_t program_id = static_cast<int64_t>(string_hash(prog_string)); | ||
|
||
const framework::BlockDesc &global_block = program_desc.Block(0); | ||
int64_t start_op_index = 0; | ||
int64_t end_op_index = static_cast<int64_t>(global_block.OpSize()); | ||
|
||
graph_ = | ||
std::make_shared<Graph>(program_desc, start_op_index, end_op_index); | ||
inner_pe_ = std::make_shared<ParallelExecutor>( | ||
place_, &scope_, execution_strategy, build_strategy, graph_.get()); | ||
inner_pe_->PrepareVariables(&scope_); | ||
inner_pe_->SkipMemoryReuse(/*scope_idx=*/0, info_->InputArgNames()); | ||
} | ||
|
||
std::vector<Tensor> operator()(const std::vector<Tensor> &inputs) { | ||
auto dense_tensors = utils::ToDenseTensors(inputs); | ||
return utils::ToTensors(this->operator()(dense_tensors)); | ||
} | ||
|
||
std::vector<DenseTensor> operator()(const std::vector<DenseTensor> &inputs) { | ||
utils::ShareIntoScope(info_->InputArgNames(), inputs, &scope_); | ||
std::vector<std::string> input_var_names = info_->InputArgNames(); | ||
std::vector<std::string> output_var_names = info_->OutputArgNames(); | ||
|
||
if (end_op_index > start_op_index) { | ||
auto cache_info = framework::GetExecutorInfoFromCache(program_desc, | ||
place_, | ||
start_op_index, | ||
end_op_index, | ||
/*is_grad=*/false, | ||
program_id, | ||
&scope_); | ||
auto ¶llel_executor = cache_info.first; | ||
auto &skip_eager_delete_vars = | ||
framework::ExecutorInfoCache::Instance().SkipEagerDeleteVars( | ||
program_id, false); | ||
if (cache_info.second /*is_new_created*/) { | ||
parallel_executor->SkipMemoryReuse(/*scope_idx=*/0, input_var_names); | ||
skip_eager_delete_vars.insert(skip_eager_delete_vars.end(), | ||
output_var_names.begin(), | ||
output_var_names.end()); | ||
|
||
framework::details::ParseSafeEagerDeletionSkipVars( | ||
program_desc, | ||
end_op_index, | ||
output_var_names, | ||
&skip_eager_delete_vars); | ||
} | ||
parallel_executor->RunWithoutFetch(skip_eager_delete_vars); | ||
} | ||
std::vector<DenseTensor> res; | ||
utils::FetchOuts(info_->OutputArgNames(), scope_, &res); | ||
return res; | ||
|
||
// update op_handle scope_map in pe->executor_->Graph | ||
std::unordered_map<framework::Scope *, framework::Scope *> scope_map = { | ||
{inner_pe_->GetLocalScopes().front(), &scope_}}; | ||
inner_pe_->ResetOpHandleScopeMapOfGraphs(scope_map); | ||
// need to recreate tmp variables in new scope | ||
inner_pe_->PrepareVariables(&scope_); | ||
|
||
inner_pe_->RunWithoutFetch(info_->OutputArgNames()); | ||
|
||
std::vector<DenseTensor> outputs; | ||
utils::FetchOuts(info_->OutputArgNames(), scope_, &outputs); | ||
scope_.DropKids(); | ||
return outputs; | ||
} | ||
|
||
const std::shared_ptr<FunctionInfo> &Info() const { return info_; } | ||
|
@@ -105,6 +136,8 @@ class PEFunction : public BaseFunction { | |
std::shared_ptr<FunctionInfo> info_; | ||
framework::Scope scope_; | ||
phi::Place place_; | ||
std::shared_ptr<ParallelExecutor> inner_pe_; | ||
std::shared_ptr<Graph> graph_; | ||
}; | ||
|
||
} // namespace jit | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我们后续可以把pe_function.h 的实现拆到.cc文件中,然后独立放到一个目录里,尽量保持头文件的简洁性
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个PR会对Function相关代码做拆分,感谢