Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI] Move oneDNN helper classes to new location #45626

Merged
merged 14 commits into from
Sep 5, 2022

Conversation

piotrekobi
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

  • Moves most classes from paddle/fluid/platform/mkldnn_reuse.h to paddle/phi/kernels/funcs/onednn/onednn_reuse.h.
  • Changes "mkldnn" to "onednn" in function, class and variable names in PHI files wherever possible

These changes will make it easier to convert oneDNN kernels to PHI, because no more changes should need to be made to the onednn_reuse.h file.

@paddle-bot
Copy link

paddle-bot bot commented Aug 31, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 31, 2022
Silv3S
Silv3S previously approved these changes Sep 1, 2022
Copy link
Member

@Silv3S Silv3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/fluid/framework/new_executor/data_transfer.cc Outdated Show resolved Hide resolved
@piotrekobi
Copy link
Contributor Author

@chenwhql @jczaja Please review & merge

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 269bd1f into PaddlePaddle:develop Sep 5, 2022
@paddle-bot
Copy link

paddle-bot bot commented Sep 5, 2022

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Caozhou1995 pushed a commit to Caozhou1995/Paddle that referenced this pull request Sep 9, 2022
* gaussian random

* mkldnn to onednn renaming

* fix merge conflicts

* remove fluid code

* onednn renaming

* Move classes from mkldnn_reuse.h to onednn_reuse.h

* Move more functions from mkldnn_helper.h to onednn_helpper.h

* Change MKLDNN to OneDNN in VLOG message

Co-authored-by: Silv3S <slawomir.siwek@intel.com>
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants