Unify core avx and core_noavx to libpaddle #46095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
pangyoki
previously approved these changes
Sep 16, 2022
才知道这个历史原因。 |
是的，需要从底层解决 |
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Sep 16, 2022
* unify core_avx and core_noavx * fix except error * revert mac compile logic * revert dylib to so * add core_noavx branch * remove core_noavx * replace paddle_core by lib paddle * polish var name * replace paddle_core by libpaddle * update custom device commit * polish code by comments
phlrain
pushed a commit
that referenced
this pull request
Sep 19, 2022
* unify core_avx and core_noavx * fix except error * revert mac compile logic * revert dylib to so * add core_noavx branch * remove core_noavx * replace paddle_core by lib paddle * polish var name * replace paddle_core by libpaddle * update custom device commit * polish code by comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
Unify core avx and core_noavx to libpaddle
之前paddle为了使一个whl包同时支持avx和noavx，采用了一种比较trick的方式，编译两遍paddle，分别编译avx和noavx，最后打包到一起，#17889
这种方式虽然解决了问题，但也引入了新的问题：
本PR清理了一些历史代码，将动态库名称统一改为
libpaddle，参考linux shared library的命名公约，https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html同时需要在PaddleCustomDevice中对这两个命名的使用增加一个if分支：https://github.com/PaddlePaddle/PaddleCustomDevice/search?q=core_avx
PaddlePaddle/PaddleCustomDevice#112