Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont wait for send op under dygraph pp #46209

Merged
merged 2 commits into from
Sep 20, 2022
Merged

dont wait for send op under dygraph pp #46209

merged 2 commits into from
Sep 20, 2022

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Sep 19, 2022

PR types

Others

PR changes

Others

Describe

bug fix for allgather partial in old dygraph fail

@paddle-bot
Copy link

paddle-bot bot commented Sep 19, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ForFishes
ForFishes previously approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu changed the title bug fix for allgather partial in old dygraph fail dont wait for send op under dygraph pp Sep 19, 2022
ForFishes
ForFishes approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu merged commit 8ff7df8 into PaddlePaddle:develop Sep 20, 2022
@FeixLiu FeixLiu deleted the use_new_send_recv_op branch September 20, 2022 03:16
FeixLiu added a commit to FeixLiu/Paddle that referenced this pull request Oct 11, 2022
@FeixLiu
dont wait for send op under dygraph pp (PaddlePaddle#46209)
6d1ccb6
fuyinno4 pushed a commit that referenced this pull request Oct 11, 2022
@FeixLiu
Cherry pick for dygraph pp (#46876)
9cc3f69 
* bug fix for virtual pipeline parallel (#45922)

* dont wait for send op under dygraph pp (#46209)

* [interleave pp] sync recv for 1f1b (#46399)

* [dygraph pp] all sync for allgather partial (#46483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForFishes ForFishes ForFishes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FeixLiu @ForFishes