Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slice bugs in MKLDNN when input dims are zeros #46671

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Fix slice bugs in MKLDNN when input dims are zeros #46671

merged 5 commits into from
Oct 11, 2022

Conversation

yeliang2258
Copy link
Contributor

@yeliang2258 yeliang2258 commented Sep 30, 2022

PR types

Bug fixes

PR changes

OPs

Describe

Fix slice bugs in MKLDNN when input dims are zeros, like [0, 0, 0, 0]

@paddle-bot
Copy link

paddle-bot bot commented Sep 30, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/fluid/operators/slice_op.cc Outdated Show resolved Hide resolved
tsocha
tsocha previously approved these changes Sep 30, 2022
jczaja
jczaja previously approved these changes Sep 30, 2022
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/fluid/operators/slice_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/slice_op.cc Outdated Show resolved Hide resolved
piotrekobi
piotrekobi previously approved these changes Sep 30, 2022
Copy link
Contributor

@piotrekobi piotrekobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiangjiajun jiangjiajun merged commit 6c2af7b into PaddlePaddle:develop Oct 11, 2022
ZeyuChen pushed a commit that referenced this pull request Nov 11, 2022
* fix slice bugs

* fix

* update code

* fix

* update code
ZeyuChen pushed a commit that referenced this pull request Nov 29, 2022
…ze_transpose for MKLDNN (#47951)

* Fix slice bugs in MKLDNN when input dims are zeros (#46671)

* fix slice bugs

* fix

* update code

* fix

* update code

* updating mul and matmul with set_mem_desc (#45624)

* - mul & matmul changes

- fix

- bs16 correction of strides

* - cosmetic fixes

* - lint

* - fix

* - fix

* - format -> mem_desc

* - fix

* - fix

* - fix

* - fix

* - fix

* fix squueze_transpose (#47911)

Co-authored-by: Jacek Czaja <jacek.czaja@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants