[CodeStyle] use built-in open instead of io.open
#46751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigureMo
commented
Oct 5, 2022
| @@ -67,7 +66,7 @@ RE_SHEBANG = re.compile(r"^[ \t\v]*#[ \t]?\!") | |||
| def _check_copyright(path): | |||
| head=[] | |||
| try: | |||
| with open(path) as f: | |||
| with open(path, 'r', encoding='utf-8') as f: | |||
There was a problem hiding this comment.
这里没有指定编码会在 Windows 上因为编码错误而无法提交，见 cattidea/paddle-flake8-project#66 (comment)
This was referenced Oct 5, 2022
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
使用 built-in
open替换io.open同样是一个 Python2 历史遗留问题，在 Python2
open与io.open不同，而在 Python3open与io.open完全相同，也更推荐使用open而不是io.open