Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix numpy issue in codeblock examples (test=document_fix) #47042

Merged
merged 1 commit into from
Oct 21, 2022
Merged

fix numpy issue in codeblock examples (test=document_fix) #47042

merged 1 commit into from
Oct 21, 2022

Conversation

kevinng77
Copy link
Contributor

PR types

Others

PR changes

Docs

Describe

Remove the third-party library numpy in API docs(example code) for operators.

@paddle-bot
Copy link

paddle-bot bot commented Oct 16, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 16, 2022
@luotao1
Copy link
Contributor

luotao1 commented Oct 18, 2022

请问这类问题还有多少个，如果量比较大的话，可以整理一个tracking issue，邀请更多的社区小伙伴来完成。

@kevinng77
Copy link
Contributor Author

请问这类问题还有多少个，如果量比较大的话，可以整理一个tracking issue，邀请更多的社区小伙伴来完成。

类似的文档示例代码 Numpy 问题还有挺多的哈，大约有还有 90 多个文件示例代码中包含了 numpy。

@Ligoml
Copy link
Contributor

Ligoml commented Oct 21, 2022

请问这类问题还有多少个，如果量比较大的话，可以整理一个tracking issue，邀请更多的社区小伙伴来完成。

类似的文档示例代码 Numpy 问题还有挺多的哈，大约有还有 90 多个文件示例代码中包含了 numpy。

嗯嗯，这类问题是比较普遍的，可以看一下自己的时间精力，如果能独立cover可以慢慢修，如果需要其他小伙伴加入就提一个tracking issue或者在PFCC的群里拉人也是可以的~

Ligoml
Ligoml approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job！
LGTM for docs

@Ligoml Ligoml merged commit a657465 into PaddlePaddle:develop Oct 21, 2022
@luotao1
Copy link
Contributor

luotao1 commented Oct 21, 2022

@kevinng77 可以贡献一个call for contribution，然后来当一下leader哈

@kevinng77
Copy link
Contributor Author

请问这类问题还有多少个，如果量比较大的话，可以整理一个tracking issue，邀请更多的社区小伙伴来完成。

类似的文档示例代码 Numpy 问题还有挺多的哈，大约有还有 90 多个文件示例代码中包含了 numpy。

嗯嗯，这类问题是比较普遍的，可以看一下自己的时间精力，如果能独立cover可以慢慢修，如果需要其他小伙伴加入就提一个tracking issue或者在PFCC的群里拉人也是可以的~

嗯嗯好，numpy问题改的方式都比较统一，我这边可以负责修改完的哈哈

@kevinng77
Copy link
Contributor Author

@kevinng77 可以贡献一个call for contribution，然后来当一下leader哈

哈哈好，第一次接触这个，我去研究下先 ：）

@kevinng77 kevinng77 deleted the fix_numpy branch October 23, 2022 16:05
@Ligoml Ligoml mentioned this pull request Nov 4, 2022
Merged
Ligoml pushed a commit that referenced this pull request Nov 4, 2022
@kevinng77 @Ligoml
#47042
b43239f
jzhang533 pushed a commit that referenced this pull request Nov 7, 2022
@Ligoml @kevinng77
[cherry-pick2.4]fix numpy issue in codeblock examples (#47664)
d580983 
* #46765

* #47042

* Remove redundant numpy import (#47483)

* #47555

* resolve conflict

* resolve conflict

* resolve conflict

* resolve conflict

* resolve conflict

* for_codestyle

* fix sample code paddle.linalg.multi_dot

Co-authored-by: Kevin吴嘉文 <417333277@qq.com>
@Ligoml Ligoml mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligoml Ligoml Ligoml approved these changes

Assignees

@Ligoml Ligoml

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinng77 @luotao1 @Ligoml