Impl optimizer #4734
Merged
Impl optimizer #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impl-optimizer
… impl-optimizer
23 tasks
… impl-optimizer
… impl-optimizer
… impl-optimizer
… impl-optimizer
… python-cpp-sync
… impl-optimizer
… into impl-optimizer
… impl-optimizer
reyoung
reviewed
Oct 16, 2017
| @@ -298,6 +302,9 @@ static void CreateGradVarInBlock( | |||
| grad_record.op_idx_ = static_cast<int>(op_index); | |||
| return false; /* not break */ | |||
| }); | |||
| if (need_infer_shape) { | |||
| @@ -305,6 +305,11 @@ def parent_idx(self): | |||
| def idx(self): | |||
| return self.desc.id | |||
|
|
|||
| def var(self, name): | |||
| if name not in self.vars: | |||
| raise Exception("var %s not in this block" % name) | |||
There was a problem hiding this comment.
| @@ -313,7 +318,9 @@ def has_var(self, name): | |||
|
|
|||
| def create_parameter(self, *args, **kwargs): | |||
| global_block = self.program.global_block() | |||
| return Parameter(global_block, *args, **kwargs) | |||
| param = Parameter(global_block, *args, **kwargs) | |||
| self.program.parameters.append(param.name) | |||
There was a problem hiding this comment.
parameters is not needed because it is recorded in vars_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: #4679
Issue: #4735