Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized oneDNN FC and added operator+unsqueeze2 and operator+reshape2 oneDNN fuse passes #47391

Merged

Conversation

jakpiase
Copy link
Contributor

PR types

New features

PR changes

OPs

Describe

Added operator+unsqueeze2 and operator+reshape2 oneDNN fuse passes. Both functionalities are in a single PR since they would conflict and time is important here. Previous PR(#47313) is abandoned due to CheckPRTemplate bug

@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 26, 2022
@jakpiase jakpiase added Intel and removed contributor External developers status: proposed labels Oct 26, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ 0x45f
✅ zh794390558
✅ jakpiase
✅ yeliang2258
❌ root


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jakpiase jakpiase force-pushed the op_unsqueeze2_reshape2_fuses branch 2 times, most recently from 1225249 to 16b74d3 Compare October 26, 2022 15:43
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Oct 26, 2022
@jakpiase jakpiase changed the title Added operator+unsqueeze2 and operator+reshape2 oneDNN fuse passes Optimized oneDNN FC and added operator+unsqueeze2 and operator+reshape2 oneDNN fuse passes Oct 27, 2022
Copy link
Contributor

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeliang2258
Copy link
Contributor

@jakpiase Is there any update to this PR?

@jakpiase
Copy link
Contributor Author

jakpiase commented Nov 3, 2022

@yeliang2258 we have run internal functionality tests and everything looks good. Could you please ask somebody to approve PR-CI-APPROVAL for ShareDataWith so we can merge and I will be able to prepare cherry-picks into release2.4?

Copy link
Contributor

@yeliang2258 yeliang2258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for shareDataWith

@jiangjiajun jiangjiajun merged commit 9e00698 into PaddlePaddle:develop Nov 4, 2022
@yeliang2258
Copy link
Contributor

@jakpiase This PR has been merged, please cherry pick to 2.4, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants