Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] remove functions not belong to public-api from __all__ #47577

Merged

Conversation

zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Nov 2, 2022

PR types

Bug fixes

PR changes

APIs

Describe

Cherry-pick #47502 to version 2.4

For apis of paddle.distributed, there are some additional changes since code in 2.4 is kind of different with branch develop:

  • remove paddle.distributed.stream (a module, not callable)
  • remove from xxx import *, this may cause some potential problem. For example, the function all_reduce(which is expected) is covered by the module all_reduce (file all_reduce.py in communication).

@paddle-bot
Copy link

paddle-bot bot commented Nov 2, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jeff41404
jeff41404 previously approved these changes Nov 2, 2022
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ligoml
Ligoml previously approved these changes Nov 2, 2022
@zoooo0820 zoooo0820 dismissed stale reviews from Ligoml and jeff41404 via 355744a November 8, 2022 06:30
Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for distributed api

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiaoguangHu01 XiaoguangHu01 merged commit 51248f8 into PaddlePaddle:release/2.4 Nov 9, 2022
@zoooo0820 zoooo0820 deleted the cherry-pick-fix_public-apis branch November 9, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants