Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] remove framework/data_type.h from phi #47776

Merged
merged 3 commits into from
Nov 9, 2022
Merged

[PHI decoupling] remove framework/data_type.h from phi #47776

merged 3 commits into from
Nov 9, 2022

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 8, 2022

PR types

Others

PR changes

Others

Describe

remove "paddle/fluid/framework/data_type.h" from phi

@paddle-bot
Copy link

paddle-bot bot commented Nov 8, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 8, 2022
@GreatV GreatV changed the title remove framework/data_type.h from phi [PHI decoupling] remove framework/data_type.h from phi Nov 8, 2022
@GreatV GreatV mentioned this pull request Nov 8, 2022
Closed
YuanRisheng
YuanRisheng reviewed Nov 9, 2022
View reviewed changes
paddle/phi/kernels/arg_min_max_kernel.h Outdated Show resolved Hide resolved
paddle/phi/core/utils/data_type.h Show resolved Hide resolved
paddle/phi/kernels/unique_consecutive_kernel.h Outdated Show resolved Hide resolved
@GreatV
Copy link
Contributor Author

GreatV commented Nov 9, 2022 •
edited
Loading

@YuanRisheng 麻烦再review一下

@YuanRisheng YuanRisheng merged commit 1631836 into PaddlePaddle:develop Nov 9, 2022
@GreatV GreatV deleted the phi_decouple branch November 9, 2022 10:07
@huangjiyi huangjiyi mentioned this pull request Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees

@luotao1 luotao1

@YuanRisheng YuanRisheng

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GreatV @YuanRisheng @luotao1