-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clean Fluid API]Remove squeeze: use paddle.squeeze to replace paddle.fluid.layers.squeeze #47938
Conversation
Modify the funcation all of squeeze. Use paddle.squeeze to replace paddle.fluid.layers.squeeze
fix some modifications which are not needless to the original format
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
python/paddle/fluid/layers/nn.py
Outdated
@@ -5440,6 +5439,7 @@ def topk(input, k, name=None): | |||
return values, indices | |||
|
|||
|
|||
# Will be removed in this project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句需要删掉吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
python/paddle/fluid/layers/nn.py
Outdated
@@ -5588,7 +5588,8 @@ def ctc_greedy_decoder( | |||
return ctc_out | |||
else: | |||
ctc_out_len = helper.create_variable_for_type_inference(dtype="int64") | |||
ctc_input = squeeze(topk_indices, [2]) | |||
# The parent function will be removed by other partner, so replace this use 2.x API temporarily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句注释后面也可以删了
remove a redundant comment.
5918f07
to
8ca57e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
APIs
Describe
Modify the function call of squeeze.
Use paddle.squeeze to replace paddle.fluid.layers.squeeze