Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clean Fluid API]Remove squeeze: use paddle.squeeze to replace paddle.fluid.layers.squeeze #47938

Merged
merged 9 commits into from
Nov 28, 2022

Conversation

Vvsmile
Copy link
Contributor

@Vvsmile Vvsmile commented Nov 14, 2022

PR types

Others

PR changes

APIs

Describe

Modify the function call of squeeze.
Use paddle.squeeze to replace paddle.fluid.layers.squeeze

	Modify the funcation all of squeeze.
	Use paddle.squeeze to replace paddle.fluid.layers.squeeze
	fix some modifications which are not needless to the original
format
@paddle-bot
Copy link

paddle-bot bot commented Nov 14, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 14, 2022
@Vvsmile Vvsmile changed the title Remove squeeze: use paddle.squeeze to replace paddle.fluid.layers.squeeze [Clean Fluid API]Remove squeeze: use paddle.squeeze to replace paddle.fluid.layers.squeeze Nov 21, 2022
lanxianghit
lanxianghit previously approved these changes Nov 21, 2022
momozi1996
momozi1996 previously approved these changes Nov 21, 2022
Copy link
Contributor

@momozi1996 momozi1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vvsmile Vvsmile dismissed stale reviews from momozi1996 and lanxianghit via a8b15d0 November 22, 2022 12:19
@@ -5440,6 +5439,7 @@ def topk(input, k, name=None):
return values, indices


# Will be removed in this project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句需要删掉吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@@ -5588,7 +5588,8 @@ def ctc_greedy_decoder(
return ctc_out
else:
ctc_out_len = helper.create_variable_for_type_inference(dtype="int64")
ctc_input = squeeze(topk_indices, [2])
# The parent function will be removed by other partner, so replace this use 2.x API temporarily
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句注释后面也可以删了

Copy link
Contributor

@momozi1996 momozi1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit 2fe9299 into PaddlePaddle:develop Nov 28, 2022
@Vvsmile Vvsmile deleted the remove_squeeze branch November 9, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants