Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] remove "gpu_primitives.h" in fluid #48063

Merged
merged 5 commits into from
Nov 18, 2022
Merged

[PHI decoupling] remove "gpu_primitives.h" in fluid #48063

merged 5 commits into from
Nov 18, 2022

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 16, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Remove "gpu_primitives.h" in fluid namespace.

@paddle-bot
Copy link

paddle-bot bot commented Nov 16, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 16, 2022
@GreatV GreatV changed the title [PHI decoupling] remove "gpu_primitives.h" in fluid namespace [PHI decoupling] remove "gpu_primitives.h" in fluid Nov 16, 2022
@GreatV GreatV mentioned this pull request Nov 17, 2022
Closed
YuanRisheng
YuanRisheng previously approved these changes Nov 17, 2022
View reviewed changes
@luotao1
Copy link
Contributor

luotao1 commented Nov 17, 2022

请解决下冲突

@GreatV
Copy link
Contributor Author

GreatV commented Nov 17, 2022

@YuanRisheng @luotao1 @XiaoguangHu01 @ZzSean 麻烦再次 review

ZzSean
ZzSean approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

XiaoguangHu01
XiaoguangHu01 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 9918bf9 into PaddlePaddle:develop Nov 18, 2022
@GreatV GreatV deleted the phi_decouple branch November 18, 2022 04:14
@GreatV GreatV mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@ZzSean ZzSean ZzSean approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees

@luotao1 luotao1

@YuanRisheng YuanRisheng

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GreatV @luotao1 @YuanRisheng @ZzSean @XiaoguangHu01