Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI decoupling] move "gpu_device_function.h" from fluid to phi #48097

Merged

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Nov 17, 2022

PR types

Others

PR changes

Others

Describe

move "fluid/platform/device/gpu/gpu_device_function.h" to phi

Changes:

  • paddle/fluid/platform/device/gpu 目录下的 gpu_device_function.h, rocm/rocm_device_function.hcuda/cuda_device_function.h 复制到 paddle/phi/backends/gpu 目录下,然后将它们与 fluid 进行解耦。
  • phi 下对 paddle/fluid/platform/device/gpu/gpu_device_function.h 的依赖替换为对 paddle/phi/backends/gpu/gpu_device_function.h 的依赖.
  • 后续再提一个PR移除原 fluid 下的头文件 [PHI decoupling] remove "gpu_device_function.h" in fluid. #48117

@paddle-bot
Copy link

paddle-bot bot commented Nov 17, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 17, 2022
@huangjiyi huangjiyi changed the title [PHI decoupling] move "fluid/platform/device/gpu/gpu_device_function.h" to phi [PHI decoupling] move "gpu_device_function.h" from fluid to phi Nov 17, 2022
@huangjiyi
Copy link
Member Author

@YuanRisheng @luotao1

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

@luotao1 luotao1 merged commit 27ee6e7 into PaddlePaddle:develop Nov 18, 2022
@huangjiyi huangjiyi deleted the decouple_gpu_device_function_h branch December 9, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants