[PHI decoupling] move im2col from fluid to phi #48174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@YuanRisheng 可以进行 review |
YuanRisheng
reviewed
Nov 22, 2022
paddle/phi/kernels/funcs/im2col.h
Outdated
Comment on lines
24
to
26
| // namespace paddle { | ||
| // namespace operators { | ||
| // namespace math { |
|
@YuanRisheng ，CI 已通过，可以再次 Review 了 |
YuanRisheng
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[phi] Decoupled phi from fluid tracking issue #47615
将
paddle/fluid/operators/math目录下的im2col.h,im2col_cfo_cpu.h,im2col.cc,im2col.cu移动至paddle/phi/kernels/funcs.im2col_test.cc仍然在paddle/fluid/operators/math目录下，因为im2col_test.cc依赖了tensor_util.h和allocator.h，不好处理，就没有移动。