Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing updates of Beta1 power accumulators outside the op #4931

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Removing updates of Beta1 power accumulators outside the op #4931

merged 1 commit into from
Oct 19, 2017

Conversation

abhinavarora
Copy link
Contributor

@abhinavarora abhinavarora commented Oct 19, 2017 •
edited
Loading

Fixes #4920

@abhinavarora abhinavarora self-assigned this Oct 19, 2017
tonyyang-svail
tonyyang-svail approved these changes Oct 19, 2017
View reviewed changes
Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@abhinavarora abhinavarora merged commit 77cac5c into PaddlePaddle:develop Oct 19, 2017
@abhinavarora abhinavarora deleted the fix_adamax branch October 19, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyyang-svail tonyyang-svail tonyyang-svail approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees

@abhinavarora abhinavarora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavarora @tonyyang-svail