[PHI]move ReshapeToMatrix & GetValue #50139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
engineer1109
force-pushed
the
getvalue
branch
9 times, most recently
from
116ab37
to
6c52aa4
Compare
YuanRisheng
reviewed
Feb 3, 2023
| @@ -867,4 +867,60 @@ template void TensorToVector(const phi::DenseTensor& src, | |||
| template void TensorToVector(const phi::DenseTensor& src, | |||
| std::vector<phi::dtype::complex<double>>* dst); | |||
|
|
|||
| phi::DenseTensor ReshapeToMatrix(const phi::DenseTensor& src, | |||
There was a problem hiding this comment.
可以把Fluid目录下的这个函数删掉，其他用到这个函数的地方使用phi::ReshapeToMatrix替代
paddle/fluid/operators/isfinite_op.h
Outdated
| @@ -129,17 +130,17 @@ inline void TensorIsfinite(const phi::DenseTensor& tensor, | |||
| inline bool TensorContainsNAN(const phi::DenseTensor& tensor) { | |||
| phi::DenseTensor out; | |||
| TensorContainsNAN(tensor, &out); | |||
| return GetValue<bool>(&out); | |||
| return phi::GetValue<bool>(&out); | |||
There was a problem hiding this comment.
这里还是不建议进行修改，Phi下新增的GetValue和Fluid下的还是有点不一样，缺少异构设备（npu，mlu）的支持，建议还是用Fluid下原本的GetValue吧
engineer1109
force-pushed
the
getvalue
branch
4 times, most recently
from
73431c7
to
bba732e
Compare
fix paddle::memory::copy to phi::Copy fix conflict template fix header remove unused fix Alloc fix Copy fix template fix template remove reshapematrix on fluid change isfinite phi move ReshapeToMatrix & GetValue fix paddle::memory::copy to phi::Copy fix conflict template fix header remove unused fix Alloc fix Copy fix template fix template remove reshapematrix on fluid change isfinite fix namespace fix header fix namespace
engineer1109
force-pushed
the
getvalue
branch
from
bba732e
to
ebcfb66
Compare
YuanRisheng
approved these changes
Feb 6, 2023
|
@luotao1 麻烦豁免一下coverage |
Done，已豁免合入 |
|
#47615 第二个 tensor_util.h |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
继续#49885 后续的迁移
PHI算子解藕代码
将ReshapeToMatrix和GetValue 从fluild的tensor_utils
删除一些代码中自己的inline GetValue，统一使用相同的GetValue
paddle/fluid/framework/tensor_util.h