Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phi decoupling] remove variable.h in phi #50407

Merged
merged 20 commits into from
Feb 16, 2023
Merged

[phi decoupling] remove variable.h in phi #50407

merged 20 commits into from
Feb 16, 2023

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Feb 10, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  • 将 paddle/phi/api/lib/utils/tensor_utils.h 中几个用到 Variable 的函数移到 fluid/framework/phi_utils.h
  • 将 ToAbsOffset 函数从 fluid lod_tensor.h 拷贝至 phi lod_utils.h

@paddle-bot
Copy link

paddle-bot bot commented Feb 10, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

YuanRisheng
YuanRisheng reviewed Feb 13, 2023
View reviewed changes
paddle/fluid/framework/variable_utils.h Outdated
@@ -0,0 +1,32 @@
// Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把这个文件尝试合入到phi_utils.h里吧，感觉又多了一个utils文件有点重复了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

XiaoguangHu01
XiaoguangHu01 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit 905cefd into PaddlePaddle:develop Feb 16, 2023
@huangjiyi
Copy link
Member Author

@huangjiyi
Copy link
Member Author

@YuanRisheng

@YuanRisheng YuanRisheng mentioned this pull request Feb 20, 2023
Closed
@huangjiyi huangjiyi deleted the move_variable branch March 8, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangjiyi @YuanRisheng @XiaoguangHu01