Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] remove reference to fluid/framework/tensor.h in phi #50475

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[PHI decoupling] remove reference to fluid/framework/tensor.h in phi #50475

merged 1 commit into from
Feb 20, 2023

Conversation

RedContritio
Copy link
Contributor

@RedContritio RedContritio commented Feb 13, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

remove reference to <paddle/fluid/framework/tensor.h> in phi

@paddle-bot
Copy link

paddle-bot bot commented Feb 13, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 13, 2023
@RedContritio RedContritio changed the title [phi] remove <fluid/framework/tensor.h> from phi [phi] remove <fluid/framework/tensor.h> from phi 【未完成先不用 review】 Feb 13, 2023
@RedContritio RedContritio changed the title [phi] remove <fluid/framework/tensor.h> from phi 【未完成先不用 review】 [phi] remove <fluid/framework/tensor.h> from phi Feb 13, 2023
@RedContritio RedContritio changed the title [phi] remove <fluid/framework/tensor.h> from phi [phi] move <fluid/framework/tensor.h> from fluid/framework to phi Feb 17, 2023
@RedContritio RedContritio changed the title [phi] move <fluid/framework/tensor.h> from fluid/framework to phi [PHI decoupling] move tensor.h from fluid/framework to phi Feb 17, 2023
@RedContritio
Copy link
Contributor Author

@YuanRisheng

YuanRisheng
YuanRisheng reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和50507一样的问题，这个头文件依然是很容易去除掉的，分析一下用到了tensor.h里哪些东西，看能否使用phi现有的数据结构替换，不需要把tensor.h整个挪动到phi下

@RedContritio RedContritio changed the title [PHI decoupling] move tensor.h from fluid/framework to phi [PHI decoupling] remove reference to fluid/framework/tensor.h in phi Feb 17, 2023
@RedContritio
Copy link
Contributor Author

和50507一样的问题，这个头文件依然是很容易去除掉的，分析一下用到了tensor.h里哪些东西，看能否使用phi现有的数据结构替换，不需要把tensor.h整个挪动到phi下

收到，已解决，替换和删除了部分 include。

@luotao1 luotao1 merged commit 1c8e15c into PaddlePaddle:develop Feb 20, 2023
@luotao1 luotao1 mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees

@luotao1 luotao1

@YuanRisheng YuanRisheng

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedContritio @YuanRisheng @luotao1