【prim】Maximum grad #51006
Merged
【prim】Maximum grad #51006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Charles-hit
reviewed
Mar 10, 2023
|
lanxianghit
approved these changes
Mar 13, 2023
| Tensor* y_grad) { | ||
| if (x_grad) { | ||
| auto x_tmp = cast<T>(greater_than<T>(x, y), out_grad.dtype()); | ||
| auto dx_res = out_grad * x_tmp; |
There was a problem hiding this comment.
make sure logic the same with kernel when x equal to y
There was a problem hiding this comment.
test x = y in #51568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Maximum grad composite rule
close broadcast comp test while with no support for axis != 1
check_prim=False in TestElementwiseBF16Op,
cause bfloat16 is not supported in
less_equal