[Hackathon NO.75] 为 Paddle-TRT 添加 expend_as_v2 算子 #51028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangjun
reviewed
Mar 6, 2023
| } | ||
| } else if (op_type_ == "expand_as_v2") { | ||
| if (inputs.find("Y") != inputs.end()) { | ||
| shape_tensor = engine_->GetITensor(op_desc.Input("Shape")[0]); |
There was a problem hiding this comment.
PR-CI-Coverage这个CI还是没有过，这是什么原因呢
zhangjun
reviewed
Mar 13, 2023
| ops_config = [ | ||
| { | ||
| "op_type": "expand_as_v2", | ||
| "op_inputs": dics_intput[0], |
zhangjun
reviewed
Mar 14, 2023
Comment on lines
241
to
249
| self.dynamic_shape.min_input_shape = { | ||
| "expand_v2_input": [1, 8, 1, 32] | ||
| } | ||
| self.dynamic_shape.max_input_shape = { | ||
| "expand_v2_input": [10, 8, 1, 32] | ||
| } | ||
| self.dynamic_shape.opt_input_shape = { | ||
| "expand_v2_input": [1, 8, 1, 32] | ||
| } |
There was a problem hiding this comment.
expand_shape也需要设置动态shape值
There was a problem hiding this comment.
expand_as_v2这个算子原生GPU部分貌似不支持shape中有-1的值，当shape中有两个-1的时候，代码报错，应该是GPU原生推理部分和TRT的推理结果无法匹配导致的。
|
请 @gzy19990617 解决下冲突 |
luotao1
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
expend_v2目前已经实现，因为expend_as_v2与expend_as_v2的input、attrs有些不同，expend_as_v2算子会调用expand_kernal.cu。
因此在expend_v2基础上完成了expend_as_v2，同时在op_converter.h中利用shuffle增加了ITensor Reshape的api，方便以后对ITensor进行reshape操作。
python测试了两种情况，一种是属性中有"target_shape"，一种是输入含有Y（此时会优化用Y的shape去expand），输入的维度和shape的维度均进行了测试，覆盖多种情况，全部通过。
