Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"add book recommender_system testing" #5143

Merged
merged 35 commits into from
Nov 2, 2017

Conversation

dzhwinter
Copy link
Contributor

@dzhwinter dzhwinter commented Oct 27, 2017

found some job to finish when test the chapter 5 in refactorization framework. Just a work list. Please review after finishing them.

  • sparse_binary_vector
  • tanh operator
  • sequence_conv_pool layer

@QiJune
Copy link
Member

QiJune commented Oct 27, 2017

We have tanh operator, it is an activation operator. Please refer to https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/activation_op.cc#L388

@dzhwinter dzhwinter changed the title "[WIP]add book recommender_system testing" "add book recommender_system testing" Oct 31, 2017
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhwinter dzhwinter merged commit 69011c1 into PaddlePaddle:develop Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants