Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "GetExpectedKernelType" into "get_expected_kernel_func.cc" #51453

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

heavyrain-lzy
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy commented Mar 9, 2023

PR types

Others

PR changes

OPs

Describe

Pcard-67001

  1. 部分静态图算子的GetExectedKernelType成员函数含有不符合规范的逻辑,这些特殊逻辑通常是由MKLDNN硬件引入,此部分代码给静态图op自动生成带来了困难。目前方案为将这些特殊的GetExectedKernelType函数抽离出来重新封装,采用invoke的方式进行调用,同时修改reduce_all,frobenius_norm验证可行性。
  2. 处理Scalar IntArray类型,如果含有support_tensor属性配置,会将对应的attrtypename重写,是的attr失去了Scalar IntArray类型信息,导致组合算子的代码生成失败,本PR修复这一问题。

@paddle-bot
Copy link

paddle-bot bot commented Mar 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@heavyrain-lzy heavyrain-lzy changed the title Test change reduce Move the "GetExpectedKernelType" into "get_expected_kernel_func.cc" Mar 12, 2023
paddle/phi/api/yaml/op_compat.yaml Outdated Show resolved Hide resolved
paddle/phi/api/yaml/op_compat.yaml Outdated Show resolved Hide resolved
paddle/fluid/operators/generator/generate_op.py Outdated Show resolved Hide resolved
paddle/fluid/operators/generator/generate_op.py Outdated Show resolved Hide resolved
paddle/fluid/operators/generator/generate_op.py Outdated Show resolved Hide resolved
YuanRisheng
YuanRisheng previously approved these changes Mar 13, 2023
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
16 out of 17 committers have signed the CLA.

✅ 2742195759
✅ cxxly
✅ Li-fAngyU
✅ jiahy0825
✅ wangxn12138
✅ xiaoguoguo626807
✅ zhiboniu
✅ enkilee
✅ zhaoyinglia
✅ pangyoki
✅ b3602sss
✅ piDack
✅ wwbitejotunn
✅ heavyrain-lzy
✅ gouzil
✅ JamesLim-sy
❌ Ackeraa
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@jiahy0825 jiahy0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyfncg zyfncg merged commit f0db1f7 into PaddlePaddle:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants