Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error #5160

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Conversation

typhoonzero
Copy link
Contributor

@typhoonzero typhoonzero commented Oct 27, 2017

Fix #5159

Xreki
Xreki previously approved these changes Oct 27, 2017
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Oct 27, 2017

[16:31:20]	The following tests FAILED:
[16:31:20]	167 - test_auc_op (Failed)
[16:31:20]	193 - test_huber_loss_op (Failed)
[16:31:20]	219 - test_lstm_unit_op (Failed)

@typhoonzero
Copy link
Contributor Author

@luotao1 I reruned the CI job.

@Xreki
Copy link
Contributor

Xreki commented Oct 27, 2017

test_auc_op also fails on my computer, you need to add the following function to auc_op:

 protected:
  // CrossEntropy's data type just determined by "X"
  framework::DataType IndicateDataType(
      const framework::ExecutionContext& ctx) const override {
    return framework::ToDataType(ctx.Input<Tensor>("Inference")->type());
  }

I tried to add this function, but it still failed.

235: ERROR: test_check_output (__main__.TestAucOp)
235: ----------------------------------------------------------------------
235: Traceback (most recent call last):
235:   File "test_auc_op.py", line 62, in test_check_output
235:     self.check_output()
235:   File "/home/liuyiqun01/github/Paddle/python/paddle/v2/framework/tests/op_test.py", line 315, in check_output
235:     self.check_output_with_place(place, atol)
235:   File "/home/liuyiqun01/github/Paddle/python/paddle/v2/framework/tests/op_test.py", line 261, in check_output_with_place
235:     outs = exe.run(program, feed=feed_map, fetch_list=fetch_list)
235:   File "/home/liuyiqun01/github/Paddle/build_paddle/build/python/build/lib-python/paddle/v2/framework/executor.py", line 65, in run
235:     self.executor.run(program.desc, scope, 0)
235: EnforceNotMet: Cannot get size of type b at [/home/liuyiqun01/github/Paddle/paddle/framework/tensor_impl.h:57]

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit 6ef9da8 into PaddlePaddle:develop Oct 27, 2017
@typhoonzero typhoonzero deleted the fix_compile_error branch December 22, 2017 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants