Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resnet #5206

Merged

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Oct 30, 2017

project: #4531

wangkuiyi
wangkuiyi previously approved these changes Oct 30, 2017
batch_id = batch_id + 1

if batch_id > 1:
if batch_id > 10:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following comment tells that two minibatches is sufficient to make the test conclusion. Should we change the comment as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted to 2, 10 is for self-test.

@@ -75,8 +189,11 @@ def conv_block(input,
data_type='int64',
program=program,
init_program=init_program)
vgg_net = vgg16_bn_drop(images, program, init_program)
predict = layers.fc(input=vgg_net,
# net = vgg16_bn_drop(images, program, init_program)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a comment to hint the users switch between VGG and ResNet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jacquesqiao jacquesqiao merged commit cdc700b into PaddlePaddle:develop Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants