Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine square_error_cost layer #5216

Merged
merged 7 commits into from
Oct 31, 2017
Merged

Conversation

QiJune
Copy link
Member

@QiJune QiJune commented Oct 30, 2017

No description provided.

@@ -295,15 +295,16 @@ def find_actual(target_name, fetch_list):
+ ") has different lod at " + str(place))
else:
idx = find_actual(out_name, fetch_list)
actual_t = outs[idx]
actual = outs[idx]
actual_t = np.array(actual)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because type of outs[idx] is LoDTensor, not numpy array. We should convert it to numpy array before comparing.

@QiJune QiJune changed the title Re-implement pow operator refine square_error_cost layer Oct 30, 2017
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for looking into this issue.

@QiJune QiJune merged commit 669786b into PaddlePaddle:develop Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants