Add fill constant like #5222
Merged
Add fill constant like #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 24, 2017 22:27
wangkuiyi
reviewed
Oct 31, 2017
| self.inputs = {'Input': np.random.random((219, 232)).astype("float32")} | ||
| self.attrs = {'value': 3.5, 'shape': [132, -1, 7], 'dim_idx': 1} | ||
|
|
||
| out = np.random.random((132, 232, 7)).astype("float32") |
There was a problem hiding this comment.
Would this RNG cause random passing/failure of unit tests?
There was a problem hiding this comment.
the random seed is fixed in the base class, i.e., OpTest.
| @@ -3,13 +3,27 @@ | |||
| from op_test import OpTest | |||
|
|
|||
|
|
|||
| class TestFillConstantBatchSizeLikeOp(OpTest): | |||
| class TestFillConstantBatchSizeLikeOp1(OpTest): | |||
There was a problem hiding this comment.
I am afraid that suffixes like 1 and 2 might not be meaningful enough.
reyoung
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.