Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.60】 overlap_add, sign 算子FP16/BF16单测完善 #52667

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 8, 2023

PR types

Others

PR changes

Others

Describe

overlap_add, sign 算子FP16/BF16单测完善
图片

文档修改
PaddlePaddle/docs#5790

@paddle-bot
Copy link

paddle-bot bot commented Apr 8, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -3631,7 +3631,7 @@ def sign(x, name=None):
Returns sign of every element in `x`: 1 for positive, -1 for negative and 0 for zero.

Args:
x (Tensor): The input tensor. The data type can be float16, float32 or float64.
x (Tensor): The input tensor. The data type can be float16, float32 or float64, uint16.
Copy link
Contributor

@ZzSean ZzSean Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档无需修改,且描述使用unit16也不合适,应使用bfloat16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已取消文档修改,使用bfloat16不能识别

@co63oc co63oc force-pushed the overlap_add branch 2 times, most recently from a1bc843 to 69f0b34 Compare April 12, 2023 08:02
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit cb6de76 into PaddlePaddle:develop Apr 13, 2023
@co63oc co63oc deleted the overlap_add branch April 18, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants