Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support auto generate for op layer_norm #53178

Merged
merged 7 commits into from
May 18, 2023

Conversation

RedContritio
Copy link
Contributor

@RedContritio RedContritio commented Apr 21, 2023

PR types

Others

PR changes

OPs

Description

  • 清理 layer_norm 算子并使其适配自动生成框架,生成对应算子
  • 更新 test_composite_layer_norm 单测代码使适配新版本

@paddle-bot
Copy link

paddle-bot bot commented Apr 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented May 6, 2023

Sorry to inform you that 3c2177c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@RedContritio RedContritio force-pushed the layer_norm branch 2 times, most recently from 8bbdfce to 0f0535d Compare May 9, 2023 07:54
@RedContritio RedContritio force-pushed the layer_norm branch 3 times, most recently from 02b6f8a to 9bbd524 Compare May 10, 2023 05:01
@RedContritio RedContritio force-pushed the layer_norm branch 2 times, most recently from c836a23 to 1ec5511 Compare May 10, 2023 12:50
@RedContritio
Copy link
Contributor Author

现有问题应该是精度不够,白天看看调整单测限制

@heavyrain-lzy
Copy link
Contributor

现有问题应该是精度不够,白天看看调整单测限制

先尝试re-run一下windows的ci,不清楚为啥一个IR的大册挂掉了

heavyrain-lzy
heavyrain-lzy previously approved these changes May 11, 2023
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedContritio
Copy link
Contributor Author

@luotao1 cmake 的相关改动,辛苦 approve

luotao1
luotao1 previously approved these changes May 11, 2023
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedContritio
Copy link
Contributor Author

@zyfncg 辛苦 approve 一下 Static-Check yaml 中 layer_norm 的改动

cmake/operators.cmake Outdated Show resolved Hide resolved
paddle/fluid/operators/CMakeLists.txt Outdated Show resolved Hide resolved
@RedContritio RedContritio dismissed stale reviews from luotao1 and heavyrain-lzy via 7ee940b May 11, 2023 15:02
@RedContritio RedContritio requested a review from zyfncg May 12, 2023 03:45
heavyrain-lzy
heavyrain-lzy previously approved these changes May 15, 2023
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zyfncg
zyfncg previously approved these changes May 15, 2023
cmake/operators.cmake Outdated Show resolved Hide resolved
@RedContritio
Copy link
Contributor Author

@luotao1 辛苦 approve

@RedContritio RedContritio requested a review from luotao1 May 15, 2023 08:39
@luotao1
Copy link
Contributor

luotao1 commented May 16, 2023

请解决下冲突

@RedContritio RedContritio dismissed stale reviews from zyfncg and heavyrain-lzy via 1b0dc69 May 16, 2023 06:29
@RedContritio RedContritio force-pushed the layer_norm branch 3 times, most recently from 19add4b to d13c4f0 Compare May 16, 2023 06:53
@@ -135,7 +135,7 @@ register_unity_group(
kron_op.cc
l1_norm_op.cc
label_smooth_op.cc
layer_norm_op.cc
generated_op
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接删除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的我试试本地加上 CINN 看看

paddle/phi/infermeta/ternary.cc Show resolved Hide resolved
paddle/phi/infermeta/ternary.cc Show resolved Hide resolved
@luotao1 luotao1 merged commit 4f07b65 into PaddlePaddle:develop May 18, 2023
@RedContritio RedContritio deleted the layer_norm branch May 18, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants