Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[static op generation] coalesce_tensor #53570

Merged
merged 3 commits into from
May 9, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented May 7, 2023

PR types

Others

PR changes

Others

Description

配置coalesce_tensor

相关链接

@paddle-bot
Copy link

paddle-bot bot commented May 7, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 7, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 7, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

inputs :
{input : Input}
outputs :
{output : Output, fused_output : FusedOutput}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attrs : 
  {size_of_dtype : user_defined_size_of_dtype}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -400,120 +400,9 @@ class CoalesceTensorOp : public framework::OperatorWithKernel {
}
};

class CoalesceTensorOpMaker : public framework::OpProtoAndCheckerMaker {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 把这个文件删除。
  2. paddle/phi/kernels/coalesce_tensor_kernel.cc约276行修改为:
PD_REGISTER_KERNEL(coalesce_tensor,
                   CPU,
                   ALL_LAYOUT,
                   phi::CoalesceTensorKernel,
                   int,
                   float,
                   double) {
  kernel->InputAt(0).SetBackend(phi::Backend::ALL_BACKEND);
  kernel->OutputAt(1).SetDataType(phi::DataType::UNDEFINED);
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gouzil
Copy link
Member Author

gouzil commented May 8, 2023

@luotao1 分配错人了

@luotao1 luotao1 assigned heavyrain-lzy and unassigned From00 May 9, 2023
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit eaed168 into PaddlePaddle:develop May 9, 2023
@gouzil gouzil deleted the autogen_code_coalesce_tensor branch May 15, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants