Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move cudnn_lstm kernel to phi #53730

Merged
merged 12 commits into from
May 16, 2023
Merged

move cudnn_lstm kernel to phi #53730

merged 12 commits into from
May 16, 2023

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented May 11, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

Pcard-67003

@paddle-bot
Copy link

paddle-bot bot commented May 11, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 11, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 11, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@huangjiyi huangjiyi mentioned this pull request May 11, 2023
Closed
@huangjiyi huangjiyi changed the title move cudnn_lstm to phi move cudnn_lstm kernel to phi May 11, 2023
@huangjiyi
Copy link
Member Author

@From00 , 帮忙 Review 一下 ~

From00
From00 approved these changes May 13, 2023
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huangjiyi
Copy link
Member Author

huangjiyi commented May 15, 2023 •
edited
Loading

@From00 ，帮忙 Rerun 一下 PR-CI-CINN，应该是之前您帮我 Rerun 了，然后我就不能 Rerun 了，还有其他的 CI 也帮忙找人 Review 一下 ~

@luotao1 luotao1 merged commit 52889e3 into PaddlePaddle:develop May 16, 2023
@huangjiyi huangjiyi deleted the move_cudnn_lstm branch August 14, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@From00 From00 From00 approved these changes

Assignees

@luotao1 luotao1

@From00 From00

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangjiyi @From00 @luotao1