【static】modify backward prune logic for EmptygradOpMaker #53746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… silu_double_grad
… silu_double_grad
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
xiaoguoguo626807
changed the title
|
增加代码生成逻辑对EmptyGradOpMaker的适配 |
chenwhql
approved these changes
May 16, 2023
zyfncg
approved these changes
May 16, 2023
Comment on lines
+1363
to
+1369
| VLOG(3) << "Prim Flag Close: Runing origin grad fun for " | ||
| << op_desc.Type(); | ||
| grad_op_descs = grad_op_maker( | ||
| op_desc, no_grad_set, &grad_to_var, grad_sub_block); | ||
| } else { | ||
| VLOG(3) << "Prim Flag Close: Runing composite grad fun for " | ||
| << op_desc.Type(); |
There was a problem hiding this comment.
这个LOG级别再降一些把，3 有点高，容易影响到其他地方的调试
There was a problem hiding this comment.
next pr will modify #53874
zyfncg
reviewed
May 16, 2023
Comment on lines
+480
to
481
| {% elif "forward" in op %} | ||
| {% else %} |
There was a problem hiding this comment.
下面还有emptyGradOpMaker的生成分支
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
pcard-66975
修复静态图 EmptyGradMaker(表示没有反向定义，如fill)与Nullptr(表示未实现，如sigmoid四阶)语义问题，backward逻辑中只剪枝反向是 EmptyGradMaker的op, 反向是nullptr的op将在get_grad_op_desc函数中抛出异常
补充composite_double_grad的approve 规则