[CustomDevice] suport device_guard for custom device #53808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
ronny1996
requested changes
May 15, 2023
| @@ -400,6 +400,18 @@ void ApplyDeviceGuard(const OperatorBase* op_base, | |||
| } | |||
| VLOG(3) << "Switch into " << expected_kernel_key->place_ | |||
| << " by device_guard."; | |||
| } else if (op_device.find("npu") != std::string::npos && | |||
… support_device_guard_for_npu
YanhuiDua
commented
May 15, 2023
python/paddle/fluid/framework.py
Outdated
| 'intel_gpu', | ||
| 'mps', | ||
| 'custom_cpu', | ||
| '', |
There was a problem hiding this comment.
这里是否先添加了所有的custom device
There was a problem hiding this comment.
这里也不用用硬编码，paddle.device.get_all_custom_device_type() 可以获取所有已注册的custom device设备类型
ronny1996
requested changes
May 15, 2023
python/paddle/fluid/framework.py
Outdated
| 'intel_gpu', | ||
| 'mps', | ||
| 'custom_cpu', | ||
| '', |
There was a problem hiding this comment.
这里也不用用硬编码，paddle.device.get_all_custom_device_type() 可以获取所有已注册的custom device设备类型
YanhuiDua
force-pushed
the
support_device_guard_for_npu
branch
from
8d65ad1
to
c8d6039
Compare
YanhuiDua
changed the title
YanhuiDua
force-pushed
the
support_device_guard_for_npu
branch
from
c8d6039
to
ffae3d4
Compare
YanhuiDua
force-pushed
the
support_device_guard_for_npu
branch
from
36f4759
to
245f669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
suport device_guard for custom device