Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] do not call check_nccl_version_for_p2p under xpu #53862

Merged

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented May 16, 2023

PR types

Bug fixes

PR changes

Others

Description

在流水线并行的时候,有个地方会去调用check_nccl_version_for_p2p来检查NCCL依赖。但是在XPU环境下根本没有NCCL,如果调用了就会打出这样一行日志

WARNING:root:No version for NCCL library found!

反而很令人费解。所以本PR去掉了这个调用。

@paddle-bot
Copy link

paddle-bot bot commented May 16, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 16, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

Copy link
Contributor

@sljlp sljlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 5d638fe into PaddlePaddle:develop May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants