-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix c++17 bug #54228
Merged
Merged
Fix c++17 bug #54228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
❌ The PR is not created using PR's template. You can refer to this Demo. |
risemeup1
force-pushed
the
fix_c++17_bug
branch
3 times, most recently
from
June 3, 2023 14:05
3f11741
to
e7dc018
Compare
zhangbo9674
approved these changes
Jun 13, 2023
YuanRisheng
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67010
修复升级cmake标准之后和c++标准后暴露的错误,均是cmake依赖的问题
主要原因:
fleet_executor
没有添加naive_executor
的依赖,但添加依赖后会在 cmake 阶段检测出循环依赖,分析后如下图:上面只是 cmake 里添加了依赖,可能代码并没有真正依赖,通过分析,
executor
代码里并没有依赖fleet_executor
,真正依赖了fleet_executor
代码的只有analysis_predictor
,而analysis_predictor
是间接通过executor
依赖fleet_executor
,所以只需要稍微调整一下 cmake 应该就可以了这里其实不够完善,因为感觉
tensorrt_engine_op_test
并没有依赖fleet_executor
,但是不加这个会在第三方库brpc
的代码报另一个第三方库leveldb
用法的undefined reference
,而且这个错误在本地能够复现:我试过加上个第三方库的依赖,但是没用,最后试着加上依赖
fleet_executor
就没问题了(fleet_executor
依赖了这两个第三方库)