[BugFix] Fix bug for binary_cross_entropy_with_logits loss #54869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
chenwhql
reviewed
Jun 27, 2023
paddle/phi/api/yaml/op_compat.yaml
Outdated
| @@ -2800,7 +2800,7 @@ | |||
| - op: sigmoid_cross_entropy_with_logits | |||
| backward: sigmoid_cross_entropy_with_logits_grad | |||
| inputs : | |||
| {x: X, label: Label} | |||
| {x: X, label: Label, pos_weight: PosWeight} | |||
There was a problem hiding this comment.
这个不用改，这是为了兼容原先的写法的，新增参数，不需要兼容旧的，后续新IR重构后原先驼峰式的命名写法都会删除
python/paddle/nn/functional/loss.py
Outdated
|
|
||
| helper.append_op( | ||
| type="sigmoid_cross_entropy_with_logits", | ||
| inputs={"X": logit, "Label": label, "PosWeight": log_weight}, |
zyfncg
reviewed
Jun 27, 2023
paddle/phi/infermeta/multiary.cc
Outdated
| @@ -3410,5 +3410,61 @@ void WeightedSampleNeighborsInferMeta(const MetaTensor& row, | |||
| out_count->set_dims({-1}); | |||
| out_count->set_dtype(DataType::INT32); | |||
| } | |||
|
|
|||
| void SigmoidCrossEntropyWithLogitsInferMeta(const MetaTensor& x, | |||
paddle/phi/infermeta/multiary.h
Outdated
| @@ -646,4 +646,12 @@ void MoeInferMeta(const MetaTensor& x, | |||
| const std::string& act_type, | |||
| MetaTensor* out); | |||
|
|
|||
| void SigmoidCrossEntropyWithLogitsInferMeta(const MetaTensor& x, | |||
DesmonDay
force-pushed
the
fix_bce_logits_loss
branch
from
70e5c66
to
673c884
Compare
chenwhql
approved these changes
Jun 28, 2023
Shixiaowei02
approved these changes
Jun 28, 2023
zyfncg
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Description
Fix bug of pos_weight calculation for binary_cross_entropy_with_logits loss. Related issue: #54730