Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CustomDevice] fix get_paddle_place #55225

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[CustomDevice] fix get_paddle_place #55225

merged 1 commit into from
Jul 10, 2023

Conversation

ronny1996
Copy link
Contributor

@ronny1996 ronny1996 commented Jul 7, 2023 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Description

fix get_paddle_place to support custom device

@paddle-bot
Copy link

paddle-bot bot commented Jul 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ronny1996 ronny1996 requested a review from qili93 July 7, 2023 10:16
qili93
qili93 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronny1996 ronny1996 closed this Jul 9, 2023
@ronny1996 ronny1996 reopened this Jul 9, 2023
@ronny1996 ronny1996 closed this Jul 9, 2023
@ronny1996 ronny1996 reopened this Jul 9, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 10, 2023
@ronny1996 ronny1996 closed this Jul 10, 2023
@ronny1996 ronny1996 reopened this Jul 10, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 10, 2023
@ronny1996 ronny1996 closed this Jul 10, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 10, 2023
@ronny1996 ronny1996 reopened this Jul 10, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 10, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 10, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 10, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 10, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 10, 2023
@ronny1996 ronny1996 marked this pull request as draft July 10, 2023 02:42
@ronny1996 ronny1996 marked this pull request as ready for review July 10, 2023 02:42
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 10, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 10, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 10, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 10, 2023
@ronny1996 ronny1996 merged commit 33730ae into PaddlePaddle:develop Jul 10, 2023
@ronny1996 ronny1996 deleted the fix_custom_place branch July 10, 2023 09:29
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
@ronny1996 @cqulilujia
[CustomDevice] fix get_paddle_place (PaddlePaddle#55225)
07fe0b5
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
@ronny1996 @wz1qqx
[CustomDevice] fix get_paddle_place (PaddlePaddle#55225)
a53301b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qili93 qili93 qili93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronny1996 @qili93