Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inference] rewrite identity_op_clean_pass #55240

Merged

Conversation

yuanlehome
Copy link
Contributor

@yuanlehome yuanlehome commented Jul 7, 2023

PR types

Others

PR changes

Others

Description

  • rewrite identity_op_clean_pass
  • add assign, concat op
  • add cpp ut and fix py ut

Others

Pcard-71500

@paddle-bot
Copy link

paddle-bot bot commented Jul 7, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@yuanlehome yuanlehome changed the title rewrite identity_op_clean_pass [Inference] rewrite identity_op_clean_pass and delete delete_assign_op_pass Jul 7, 2023
zhupengyang
zhupengyang previously approved these changes Jul 7, 2023
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanlehome yuanlehome force-pushed the rewrite_identity_op_clean_pass branch 3 times, most recently from bc08b14 to ad07493 Compare July 7, 2023 11:03
@yuanlehome yuanlehome force-pushed the rewrite_identity_op_clean_pass branch from ad07493 to a8f83ca Compare July 8, 2023 02:10
@yuanlehome yuanlehome changed the title [Inference] rewrite identity_op_clean_pass and delete delete_assign_op_pass [Inference] rewrite identity_op_clean_pass Jul 8, 2023
@yuanlehome yuanlehome force-pushed the rewrite_identity_op_clean_pass branch from 88163f6 to bbb7a24 Compare July 10, 2023 03:02
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 10, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 10, 2023
@yuanlehome yuanlehome force-pushed the rewrite_identity_op_clean_pass branch from 60c329f to 0ae9257 Compare July 11, 2023 11:49
@@ -221,7 +221,6 @@ const std::vector<std::string> kCINNCompilerPasses{
GpuPassStrategy::GpuPassStrategy() : PassStrategy({}) {
passes_.assign({
"map_op_to_another_pass", //
"identity_op_clean_pass", //
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥移动了这个pass的位置呢?

@yuanlehome yuanlehome merged commit 2363e62 into PaddlePaddle:develop Jul 12, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
* rewrite identity_op_clean_pass

* fix

* adjust identity_op_clean_pass order in gpu passes

* fix ut
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
* rewrite identity_op_clean_pass

* fix

* adjust identity_op_clean_pass order in gpu passes

* fix ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants