Add mp_all_reduce asynchronize overlap. #55662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to inform you that 0524262's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
FeixLiu
changed the title
control following behaviors: 1. export Flags_mp_aysnc_allreduce=True to turn on mp async all_reduce 2. export Flags_skip_mp_c_identity=True to skip two c_identity operators in dygraph mode. 3. export Flags_fused_linear_param_grad_add to enable fused_linear_param_grad_add in ColumnParallel backward with mp async all_reduce.
FeixLiu
reviewed
Aug 11, 2023
Xreki
reviewed
Aug 11, 2023
| task.wait() | ||
| return dx, dw, dbias | ||
| else: | ||
| dw = paddle.matmul( |
There was a problem hiding this comment.
这个分支引入了一些reshape，会不会导致一些模型变慢？
There was a problem hiding this comment.
这里的reshape只是改变了数据的逻辑shape，没有进行数据搬移。实测对性能是没啥影响的，timeline的kernel执行时间也是一致的。
FeixLiu
reviewed
Aug 14, 2023
FeixLiu
previously approved these changes
Aug 15, 2023
tianshuo78520a
approved these changes
Aug 16, 2023
FeixLiu
approved these changes
Aug 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
PCard-70444.
Add mp_all_reduce asynchronize overlap.
Use environment flags to control following behaviors:
export Flags_mp_aysnc_allreduce=Trueto turn on mp async all_reduceexport Flags_skip_mp_c_identity=Trueto skip two c_identity operators in dygraph mode.export Flags_fused_linear_param_grad_add=Trueto enable fused_linear_param_grad_add in ColumnParallelLinear backward with mp async all_reduce.