【new ir】add __eq__ and __hash__ to compare opresult and value #55909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
reviewed
Aug 2, 2023
| return false; | ||
| } | ||
| }) | ||
| .def("__eq__", &OpResult::operator==) |
There was a problem hiding this comment.
下面的判断opresult == value 的重载
YuanRisheng
approved these changes
Aug 2, 2023
Aurelius84
approved these changes
Aug 3, 2023
| .dyn_cast<ir::BoolAttribute>() | ||
| .data(); | ||
| } else { | ||
| return false; |
There was a problem hiding this comment.
若没有定义stop_gradient属性，默认策略是False，这个要留意下后续是否有什么影响
| friend Operation; | ||
|
|
||
| detail::ValueImpl *value_impl() const; |
There was a problem hiding this comment.
这里为什么不返回const detail::ValueImpl * ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-67164
增加opresult 结构和 value 结构判等方法__eq__; hash，使得指向相同地址的opresult 和 value 在python端可以判断正确（==, is, value in opresult_set)