-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add conv3d_trans_cudnn_op #5603
add conv3d_trans_cudnn_op #5603
Conversation
c2ab087
to
ec70f0b
Compare
ec70f0b
to
6fb4bb8
Compare
… Add_conv3d_transpose_cudnn_op
b19b25e
to
6e5a726
Compare
6e5a726
to
0bc2f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ops::GemmConvTransposeKernel<paddle::platform::CPUPlace, float>); | ||
REGISTER_OP_CPU_KERNEL( | ||
conv3d_transpose_cudnn_grad, | ||
ops::GemmConvTransposeGradKernel<paddle::platform::CPUPlace, float>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REGISTER double for these ops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
REGISTER_OP_GPU_KERNEL(conv3d_transpose_cudnn, | ||
ops::CudnnConvTransposeOpKernel<float>); | ||
REGISTER_OP_GPU_KERNEL(conv3d_transpose_cudnn_grad, | ||
ops::CudnnConvTransposeGradOpKernel<float>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no double for these ops. Please add in next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
fix #5617