Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdoctest] reformat example code with google style in No.31-35 #56051

Merged
merged 2 commits into from
Aug 9, 2023
Merged

[xdoctest] reformat example code with google style in No.31-35 #56051

merged 2 commits into from
Aug 9, 2023

Conversation

Kaedeharai
Copy link
Contributor

@Kaedeharai Kaedeharai commented Aug 8, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

修改如下文件的示例代码，使其通过 xdoctest 检查：

  • python/paddle/nn/initializer/dirac.py
  • python/paddle/nn/initializer/initializer.py
  • python/paddle/nn/initializer/kaiming.py
  • python/paddle/nn/initializer/normal.py
  • python/paddle/nn/initializer/orthogonal.py

预览：

Related links

@sunzhongkai588 @SigureMo @megemini

@paddle-bot
Copy link

paddle-bot bot commented Aug 8, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 8, 2023
@SigureMo SigureMo self-requested a review August 8, 2023 02:39
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 8, 2023
@luotao1 luotao1 mentioned this pull request Aug 8, 2023
Closed
sunzhongkai588
sunzhongkai588 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
代码示例修改的很好～整体看下来没有问题。现在文档预览工具出了些问题，后续我再配合预览看看

SigureMo
SigureMo approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

等孙师傅看看预览，没问题应该就可以合了

@luotao1 luotao1 merged commit 4eba647 into PaddlePaddle:develop Aug 9, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 9, 2023

hi, @Kaedeharai

  • 非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kaedeharai @luotao1 @SigureMo @sunzhongkai588