[AMP][Custom Device] add fp16 op detection for custom device #56053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jinyouzhi
changed the title
|
@zyfncg Could you help review this PR? |
@zhangting2020 Please help review this PR~🙏🏻 |
|
@ronny1996 @zhangting2020 Could you give some comments? |
|
Note that similar work #56176 merged, very appreciate it. But it still not workable: >>> import paddle
I0811 00:41:31.618554 1720908 init.cc:239] ENV [CUSTOM_DEVICE_ROOT]=/home/afas/miniconda3/envs/youzhi_ernie/lib/python3.10/site-packages/paddle_custo m_device
I0811 00:41:31.618577 1720908 init.cc:145] Try loading custom device libs from: [/home/afas/miniconda3/envs/youzhi_ernie/lib/python3.10/site-packages/paddle_custom_device]
I0811 00:41:31.711321 1720908 custom_device.cc:1112] Successed in loading custom runtime in lib: /home/afas/miniconda3/envs/youzhi_ernie/lib/python3.10/site-packages/paddle_custom_device/libpaddle-custom-intel-gpu.so
I0811 00:41:31.711938 1720908 custom_kernel.cc:76] Successed in loading 94 custom kernel(s) from loaded lib(s), will be used like native ones.
I0811 00:41:31.711964 1720908 init.cc:157] Finished in LoadCustomDevice with libs_path: [/home/afas/miniconda3/envs/youzhi_ernie/lib/python3.10/site-packages/paddle_custom_device]
I0811 00:41:31.711975 1720908 init.cc:245] CustomDevice: intel_gpu, visible devices count: 4
>>> from paddle.fluid import core
>>> dt = core.VarDesc.VarType.FP16
>>> core.op_supported_infos('intel_gpu', dt)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: (InvalidArgument) The argument `place` should be 'GPU', 'CPU', 'XPU', but got 'intel_gpu'.
[Hint: Expected is_target_place.count(query_place) != 0, but received is_target_place.count(query_place):0 == 0:0.] (at /home/afas/youzhi/pd-main/paddle/fluid/imperative/amp_auto_cast.cc:56)
>>> exit()I propose to adopt a more compatible way, rather than hard code as 'CUSTOM_DEVICE' for custom device's name. |
jinyouzhi
added a commit
to jinyouzhi/Paddle
that referenced
this pull request
Aug 23, 2023
…addle#56053) * [AMP] add fp16 op detection for custom device * resolve conflicts
jinyouzhi
added a commit
to jinyouzhi/Paddle
that referenced
this pull request
Aug 24, 2023
…addle#56053) * [AMP] add fp16 op detection for custom device * resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
Aim to support the fp16 dtype op detection in AMP for custom device.