Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pooling functor parameter order #5608

Merged
merged 1 commit into from
Nov 14, 2017
Merged

fix pooling functor parameter order #5608

merged 1 commit into from
Nov 14, 2017

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Nov 13, 2017 •
edited
Loading

fix #5616

@chengduoZH chengduoZH force-pushed the fix_pooling_function_parameter_order branch 2 times, most recently from a17c0e2 to 7b21d95 Compare November 13, 2017 15:05
@chengduoZH chengduoZH force-pushed the fix_pooling_function_parameter_order branch from 7b21d95 to 2160497 Compare November 13, 2017 15:53
qingqing01
qingqing01 approved these changes Nov 14, 2017
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chengduoZH chengduoZH merged commit feaf1e2 into PaddlePaddle:develop Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

@sweetsky0901 sweetsky0901 Awaiting requested review from sweetsky0901

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix pooling functor parameter order
2 participants
@chengduoZH @qingqing01