-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xdoctest][task 141] Reformat example code with google style in quantization/post_training_quantization.py #56238
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
✅ This PR's description meets the template requirements! |
ptq.quantize() | ||
ptq.save_quantized_model(save_model_path) | ||
|
||
>>> # doctest: +SKIP(This code sample is not completed, NEED TO BE FIXED!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NEED TO BE FIXED
,不是需要修复吧,应该是这段代码所需的文件在 CI 环境不存在吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段 code 本身是跑不通的,似乎是许久没有维护了,而且是量化相关的功能,所以我这里标记了 NEED TO BE FIXED,我觉得需要飞桨负责此功能的 RD 一起来看下?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看只是 save_model_path
、sample_generator
等示例变量不存在啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我尝试指定过,是不行的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以参考 #55754 里面的单测改写一下,我看 sample_generator 已经 deprecated 了
@@ -249,39 +249,41 @@ def __init__( | |||
|
|||
Examples: | |||
.. code-block:: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还有这里缩进层级也得整体 +1,quantization 下这个问题非常严重
Sorry to inform you that aa97bb6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow 🐾
…ization/post_training_quantization.py (PaddlePaddle#56238) * [xdoctest][task 141] test=docs_preview * fix indent and update skip reason * update sample code --------- Co-authored-by: SigureMo <sigure.qaq@gmail.com>
…ization/post_training_quantization.py (PaddlePaddle#56238) * [xdoctest][task 141] test=docs_preview * fix indent and update skip reason * update sample code --------- Co-authored-by: SigureMo <sigure.qaq@gmail.com>
PR types
Others
PR changes
Docs
Description
对应tracking issue: #55629
预览链接: