Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xdoctest][task 141] Reformat example code with google style in quantization/post_training_quantization.py #56238

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

Candy2Tang
Copy link
Contributor

@Candy2Tang Candy2Tang commented Aug 13, 2023

PR types

Others

PR changes

Docs

Description

对应tracking issue: #55629
预览链接:

  • en: 生成中...
  • zh: 生成中...

@paddle-bot
Copy link

paddle-bot bot commented Aug 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 13, 2023
@paddle-bot
Copy link

paddle-bot bot commented Aug 13, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@Candy2Tang Candy2Tang changed the title [xdoctest][task 141] test=docs_preview [xdoctest][task 141] Reformat example code with google style in quantization/post_training_quantization.py Aug 13, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Aug 14, 2023
ptq.quantize()
ptq.save_quantized_model(save_model_path)

>>> # doctest: +SKIP(This code sample is not completed, NEED TO BE FIXED!)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEED TO BE FIXED,不是需要修复吧,应该是这段代码所需的文件在 CI 环境不存在吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段 code 本身是跑不通的,似乎是许久没有维护了,而且是量化相关的功能,所以我这里标记了 NEED TO BE FIXED,我觉得需要飞桨负责此功能的 RD 一起来看下?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看只是 save_model_pathsample_generator 等示例变量不存在啊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我尝试指定过,是不行的。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以参考 #55754 里面的单测改写一下,我看 sample_generator 已经 deprecated 了

@@ -249,39 +249,41 @@ def __init__(

Examples:
.. code-block:: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这里缩进层级也得整体 +1,quantization 下这个问题非常严重

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 27, 2023

Sorry to inform you that aa97bb6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit ebe1bd7 into PaddlePaddle:develop Sep 18, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
…ization/post_training_quantization.py (PaddlePaddle#56238)

* [xdoctest][task 141] test=docs_preview

* fix indent and update skip reason

* update sample code

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…ization/post_training_quantization.py (PaddlePaddle#56238)

* [xdoctest][task 141] test=docs_preview

* fix indent and update skip reason

* update sample code

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants