[Doctest]fix No.163,164,166, test=docs_preview #56527

liyongchao911 · 2023-08-22T03:42:02Z

PR types

Others

PR changes

Others

Description

修改如下文件的示例代码，使其通过 xdoctest 检查：

python/paddle/vision/models/squeezenet.py
python/paddle/vision/models/vgg.py
python/paddle/vision/transforms/functional.py

Related links

@sunzhongkai588 @SigureMo @megemini

paddle-bot · 2023-08-22T03:42:06Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

megemini · 2023-08-22T10:21:07Z

python/paddle/vision/transforms/functional.py

+            >>> flpped_img = F.hflip(fake_img)
+            >>> print(flpped_img.size)


flpped_img -> flipped_img

megemini · 2023-08-22T10:21:16Z

python/paddle/vision/transforms/functional.py

+            >>> flpped_img = F.vflip(fake_img)
+            >>> print(flpped_img.size)


flpped_img -> flipped_img

megemini · 2023-08-22T10:22:50Z

python/paddle/vision/transforms/functional.py

+            >>> # doctest: +SKIP('random sample')

-            fake_img = (np.random.rand(256, 300, 3) * 255.).astype('uint8')
+            >>> fake_img = (np.random.rand(256, 300, 3) * 255.).astype('uint8')
+            >>> fake_img = Image.fromarray(fake_img)
+
+            >>> print(fake_img.load()[1,1])
+            (95, 127, 202)
+            >>> converted_img = F.adjust_brightness(fake_img, 0.5)
+            >>> print(converted_img.load()[1,1])
+            (47, 63, 101)
+            >>> # doctest: -SKIP


用 seed，不需要 skip ～

megemini · 2023-08-22T10:24:19Z

python/paddle/vision/transforms/functional.py

-            gray_img = F.to_grayscale(fake_img)
-            print(gray_img.size)
+            >>> gray_img = F.to_grayscale(fake_img)
+            >>> print(gray_img.size)


megemini · 2023-08-22T10:24:59Z

python/paddle/vision/transforms/functional.py

-            print(normalized_img.max(), normalized_img.min())
+            >>> normalized_img = F.normalize(fake_img, mean, std, data_format='HWC')
+            >>> print(normalized_img.max(), normalized_img.min())
+            (300, 256)


输出不对～

megemini · 2023-08-22T10:25:45Z

python/paddle/vision/transforms/functional.py

+            >>> # doctest: +SKIP('random sample')
+            >>> fake_img = paddle.randn((3, 2, 4)).astype(paddle.float32)
+            >>> print(fake_img)
+
+            Tensor(shape=[3, 2, 4], dtype=float32, place=Place(gpu:0), stop_gradient=True,
+            [[[ 0.02169025, -0.97859967, -1.39175487, -1.07478464],
+              [ 0.20654772,  1.74624777,  0.32268861, -0.13857445]],
+            [[-0.14993843,  1.10793507, -0.40056887, -1.94395220],
+            [ 0.41686651,  0.44551995, -0.09356714, -0.60898107]],
+            [[-0.24998808, -1.47699273, -0.88838995,  0.42629015],
+            [ 0.56948012, -0.96200180,  0.53355658,  3.20450878]]])
+
+            >>> values = paddle.zeros((1,1,1), dtype=paddle.float32)
+            >>> result = paddle.vision.transforms.erase(fake_img, 0, 1, 1, 2, values)
+
+            >>> print(result)
+
+            Tensor(shape=[3, 2, 4], dtype=float32, place=Place(gpu:0), stop_gradient=True,
+            [[[ 0.02169025,  0.        ,  0.        , -1.07478464],
+            [ 0.20654772,  1.74624777,  0.32268861, -0.13857445]],
+
+            [[-0.14993843,  0.        ,  0.        , -1.94395220],
+            [ 0.41686651,  0.44551995, -0.09356714, -0.60898107]],
+
+            [[-0.24998808,  0.        ,  0.        ,  0.42629015],
+            [ 0.56948012, -0.96200180,  0.53355658,  3.20450878]]])


用 seed ～另外，最好把方括号对齐一下～

… add_xdoctest2

SigureMo

自行看下 log 吧，还有很多对不上的

SigureMo · 2023-08-27T11:31:04Z

python/paddle/vision/transforms/functional.py

-            print(normalized_img.max(), normalized_img.min())
+            >>> normalized_img = F.normalize(fake_img, mean, std, data_format='HWC')
+            >>> print(normalized_img.max(), normalized_img.min())
+            (0.99215686 -1.0)


SigureMo

点错了，不应该 approve 的

megemini · 2023-08-28T04:42:18Z

python/paddle/vision/transforms/functional.py

+
+            >>> fake_img = (np.random.rand(256, 300, 3) * 255.).astype('uint8')
+            >>> fake_img = Image.fromarray(fake_img)
+             >>> print(fake_img.size)


多了一个空格～

megemini · 2023-08-28T04:54:36Z

python/paddle/vision/transforms/functional.py

+            >>> print(fake_img)
+            Tensor(shape=[3, 2, 4], dtype=float32, place=Place(cpu), stop_gradient=True,
+            [[[ 0.06132207,  1.11349595,  0.41906244, -0.24858207],
+            [-1.85169315, -1.50370061,  1.73954511,  0.13331604]],
+
+            [[ 1.66359663, -0.55764782, -0.59911072, -0.57773495],
+            [-1.03176904, -0.33741450, -0.29695082, -1.50258386]],
+
+            [[ 0.67233968, -1.07747352,  0.80170447, -0.06695852],
+            [-1.85003340, -0.23008066,  0.65083790,  0.75387722]]])


输出不要空行～另外，可以对齐一下方括号～

Tensor(shape=[3, 2, 4], dtype=float32, place=Place(cpu), stop_gradient=True, [[[ 0.06132207, 1.11349595, 0.41906244, -0.24858207], [-1.85169315, -1.50370061, 1.73954511, 0.13331604]], [[ 1.66359663, -0.55764782, -0.59911072, -0.57773495], [-1.03176904, -0.33741450, -0.29695082, -1.50258386]], [[ 0.67233968, -1.07747352, 0.80170447, -0.06695852], [-1.85003340, -0.23008066, 0.65083790, 0.75387722]]])

megemini · 2023-08-28T05:16:22Z

python/paddle/vision/transforms/functional.py

+            Tensor(shape=[3, 2, 4], dtype=float32, place=Place(cpu), stop_gradient=True,
+            [[[ 0.06132207,  0.        ,  0.        , -0.24858207],
+            [-1.85169315, -1.50370061,  1.73954511,  0.13331604]],
+
+            [[ 1.66359663,  0.        ,  0.        , -0.57773495],
+            [-1.03176904, -0.33741450, -0.29695082, -1.50258386]],
+
+            [[ 0.67233968,  0.        ,  0.        , -0.06695852],
+            [-1.85003340, -0.23008066,  0.65083790,  0.75387722]]])


megemini

有个地方写了很多空行，清理一下吧～其他的我这边没啥问题了～

megemini · 2023-08-29T11:02:10Z

python/paddle/vision/transforms/functional.py


-            import numpy as np
-            from PIL import Image
-            from paddle.vision.transforms import functional as F

-            fake_img = (np.random.rand(256, 300, 3) * 255.).astype('uint8')

-            fake_img = Image.fromarray(fake_img)
-            print(fake_img.size) # (300, 256)
-            print(fake_img.load()[1,1]) # (95, 127, 202)
-            converted_img = F.adjust_brightness(fake_img, 0.5)
-            print(converted_img.size) # (300, 256)
-            print(converted_img.load()[1,1]) # (47, 63, 101)




这里好多空行～是不是要整体修改一下 Codestyle ~

SigureMo

LGTMeow 🐾

[Doctest]fix No.163,164,166, test=docs_preview

aea18cc

paddle-bot bot added contributor External developers status: proposed labels Aug 22, 2023

update

f21ecd4

megemini reviewed Aug 22, 2023

View reviewed changes

luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 22, 2023

luotao1 assigned luotao1, SigureMo and sunzhongkai588 Aug 22, 2023

liyongchao911 added 2 commits August 27, 2023 09:42

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

c87b9fb

… add_xdoctest2

update

e5a2876

SigureMo approved these changes Aug 27, 2023

View reviewed changes

SigureMo requested changes Aug 27, 2023

View reviewed changes

megemini reviewed Aug 28, 2023

View reviewed changes

Ligoml removed the status: proposed label Aug 28, 2023

update

fa4db29

megemini reviewed Aug 29, 2023

View reviewed changes

udpate

89351d9

SigureMo approved these changes Sep 1, 2023

View reviewed changes

luotao1 merged commit a277fe4 into PaddlePaddle:develop Sep 1, 2023

luotao1 mentioned this pull request Sep 1, 2023

[xdoctest] 分批次修改已有代码的示例 #55629

Closed

BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023

[Doctest]fix No.163,164,166, test=docs_preview (PaddlePaddle#56527)

ea4d770

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Doctest]fix No.163,164,166, test=docs_preview #56527

[Doctest]fix No.163,164,166, test=docs_preview #56527

liyongchao911 commented Aug 22, 2023

paddle-bot bot commented Aug 22, 2023

megemini Aug 22, 2023

liyongchao911 Aug 27, 2023

megemini Aug 22, 2023

liyongchao911 Aug 27, 2023

megemini Aug 22, 2023

liyongchao911 Aug 27, 2023

megemini Aug 22, 2023

liyongchao911 Aug 27, 2023

megemini Aug 22, 2023

liyongchao911 Aug 27, 2023

megemini Aug 22, 2023

liyongchao911 Aug 27, 2023

SigureMo left a comment

SigureMo Aug 27, 2023

SigureMo left a comment

megemini Aug 28, 2023

megemini Aug 28, 2023

megemini Aug 28, 2023

megemini left a comment

megemini Aug 29, 2023

SigureMo left a comment

		>>> flpped_img = F.hflip(fake_img)
		>>> print(flpped_img.size)

		>>> flpped_img = F.vflip(fake_img)
		>>> print(flpped_img.size)

[Doctest]fix No.163,164,166, test=docs_preview #56527

[Doctest]fix No.163,164,166, test=docs_preview #56527

Conversation

liyongchao911 commented Aug 22, 2023

PR types

PR changes

Description

Related links

paddle-bot bot commented Aug 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SigureMo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SigureMo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

megemini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SigureMo left a comment

Choose a reason for hiding this comment