[NewIR] add_n and combine support selected rows #56754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… simnet_support_sr
kangguangli
reviewed
Sep 1, 2023
| @@ -195,3 +195,5 @@ test_where_op | |||
| test_yolo_box_op | |||
| test_yolov3_loss_op | |||
| test_fill_constant_op | |||
| test_simnet | |||
There was a problem hiding this comment.
动转静单测的话修改这里没有用，可以参考 #56631 。目前新IR对动转静单测的监控是通过添加装饰器进行的
… simnet_support_sr
zhangbo9674
approved these changes
Sep 6, 2023
Aurelius84
changed the title
Aurelius84
approved these changes
Sep 6, 2023
|
|
||
| VLOG(4) << "Builder construction outputs"; | ||
| ir::VectorType inputs = inputs_.type().dyn_cast<ir::VectorType>(); | ||
| (void)inputs; |
|
|
||
| VLOG(4) << "Builder construction outputs"; | ||
| ir::VectorType inputs = inputs_.type().dyn_cast<ir::VectorType>(); | ||
| (void)inputs; |
kangguangli
approved these changes
Sep 6, 2023
| @@ -1112,8 +1112,8 @@ struct AddNOpTranscriber : public OpTranscriber { | |||
| } | |||
| const auto& op_info = ctx->GetRegisteredOpInfo(target_op_name); | |||
| if (!op_info) { | |||
| IR_THROW( | |||
| "Op assign_value should have corresponding OpInfo pd.assign_value_"); | |||
| IR_THROW("Op assign_value should have corresponding OpInfo %s", | |||
There was a problem hiding this comment.
Suggested change
| IR_THROW("Op assign_value should have corresponding OpInfo %s", | |
| IR_THROW("Op %s should have corresponding OpInfo %s", |
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
* add_n and combine support selected rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
调通test_simnet和test_simnet_v2
add_n和combine支持了SelectedRows
Pcard-67164