Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Device]fix symbol redefined #56766

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

engineer1109
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix #56763

CheckTensorsInDifferentDevices changed to inline to avoid symbol bugs.

@paddle-bot
Copy link

paddle-bot bot commented Aug 29, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@engineer1109
Copy link
Contributor Author

@ronny1996

Copy link
Contributor

@ronny1996 ronny1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engineer1109
Copy link
Contributor Author

这个Windows CI是 不行了。

2023-08-30 15:53:08 fatal: unable to access 'https://github.com/PaddlePaddle/Paddle.git/': The requested URL returned error: 403```

@engineer1109
Copy link
Contributor Author

@ronny1996 PR-CI-Windows 没有权限重启

@engineer1109
Copy link
Contributor Author

@ronny1996 CI已经完成了,是否可以Merge

@ronny1996 ronny1996 merged commit 413ca98 into PaddlePaddle:develop Sep 4, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CCL]CheckTensorsInDifferentDevices存在同名重复定义,导致编译失败
2 participants